mirror of
https://github.com/discourse/discourse.git
synced 2025-05-29 00:20:54 +08:00
DEV: Add framework for filtered plugin registers (#9763)
* DEV: Add framework for filtered plugin registers Plugins often need to add values to a list, and we need to filter those lists at runtime to ignore values from disabled plugins. This commit provides a re-usable way to do that, which should make it easier to add new registers in future, and also reduce repeated code. Follow-up commits will migrate existing registers to use this new system * DEV: Migrate user and group custom field APIs to plugin registry This gives us a consistent system for checking plugin enabled state, so we are repeating less logic. API changes are backwards compatible
This commit is contained in:
@ -46,7 +46,7 @@ RSpec.describe Admin::GroupsController do
|
||||
end
|
||||
|
||||
after do
|
||||
Group.plugin_editable_group_custom_fields.clear
|
||||
DiscoursePluginRegistry.reset!
|
||||
end
|
||||
|
||||
it "only updates allowed user fields" do
|
||||
@ -63,7 +63,7 @@ RSpec.describe Admin::GroupsController do
|
||||
end
|
||||
|
||||
it "is secure when there are no registered editable fields" do
|
||||
Group.plugin_editable_group_custom_fields.clear
|
||||
DiscoursePluginRegistry.reset!
|
||||
params = group_params
|
||||
params[:group].merge!(custom_fields: { test: :hello1, test2: :hello2 })
|
||||
|
||||
|
Reference in New Issue
Block a user