github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: show lightbox for small images (#29140)

Browse Source 
We want to allow lightboxing of smaller images, even if they are below the minimum size for image thumbnail generation.

This change sets a minimum threshold of 100 x 100 pixels for triggering the lightbox.

---------

Co-authored-by: Régis Hanol <regis@hanol.fr>
This commit is contained in:
David Battersby
2024-10-18 09:45:08 +04:00
committed by GitHub
parent 11017b20f8
commit 48308a5ee6
3 changed files with 57 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spec/lib/email/sender_spec.rb
View File

@ -636,7 +636,7 @@ RSpec.describe Email::Sender do
@secure_image_2 =
UploadCreator.new(
file_from_fixtures("logo-dev.png", "images"),
"secuere_logo_2.png",
"secure_logo_2.png",
).create_for(Discourse.system_user.id)
@secure_image_2.update_secure_status(override: true)
@secure_image_2.update(access_control_post_id: reply.id)
@ -666,7 +666,7 @@ RSpec.describe Email::Sender do
@secure_image_2 =
UploadCreator.new(
file_from_fixtures("logo-dev.png", "images"),
file_from_fixtures("logo.png", "images"),
"something-cool.png",
).create_for(Discourse.system_user.id)
@secure_image_2.update_secure_status(override: true)
@ -701,6 +701,7 @@ RSpec.describe Email::Sender do
expect(summary.attachments.map(&:filename)).to include(
*[@secure_image, @secure_image_2, @secure_image_3].map(&:original_filename),
)
expect(summary.attachments.size).to eq(3)
expect(summary.to_s.scan("Content-Type: text/html;").length).to eq(1)
expect(summary.to_s.scan("Content-Type: text/plain;").length).to eq(1)
expect(summary.to_s.scan(/cid:[\w\-@.]+/).length).to eq(3)