From 49e7124a5e1397fb1d42184d722e629ededf11eb Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 7 Feb 2017 10:41:27 -0500 Subject: [PATCH] clarify override semantics in spec --- spec/models/discourse_single_sign_on_spec.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/spec/models/discourse_single_sign_on_spec.rb b/spec/models/discourse_single_sign_on_spec.rb index 29218fb2baa..534cfb857fa 100644 --- a/spec/models/discourse_single_sign_on_spec.rb +++ b/spec/models/discourse_single_sign_on_spec.rb @@ -283,19 +283,19 @@ describe DiscourseSingleSignOn do sso } - it 'can set title if supplied on new users' do + it 'sets title correctly' do user = sso.lookup_or_create_user(ip_address) expect(user.title).to eq(sso.title) - end - it 'sets the title if user has an empty title' do - sso.title = ' ' + sso.title = "farmer" user = sso.lookup_or_create_user(ip_address) - sso.title = 'I am a new title' + expect(user.title).to eq("farmer") + + sso.title = nil user = sso.lookup_or_create_user(ip_address) - expect(user.title).to eq(sso.title) + expect(user.title).to eq("farmer") end end