github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 03:35:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: return 429 when admin api key is limited on admin route

Browse Source 
This also handles a general case where exceptions leak out prior to being handled by the application controller
This commit is contained in:
Sam
2018-01-12 14:15:10 +11:00
parent dcbaf2f213
commit 49ed382c2a
39 changed files with 322 additions and 349 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/requests/users_email_controller_spec.rb
View File

@ -67,9 +67,8 @@ describe UsersEmailController do
let(:new_email) { 'bubblegum@adventuretime.ooo' }
it "requires you to be logged in" do
expect do
put "/u/asdf/preferences/email.json"
end.to raise_error(Discourse::NotLoggedIn)
put "/u/asdf/preferences/email.json"
expect(response.status).to eq(403)
end
context 'when logged in' do
@ -80,9 +79,8 @@ describe UsersEmailController do
end
it 'raises an error without an email parameter' do
expect do
put "/u/#{user.username}/preferences/email.json"
end.to raise_error(ActionController::ParameterMissing)
put "/u/#{user.username}/preferences/email.json"
expect(response.status).to eq(400)
end
it "raises an error if you can't edit the user's email" do