github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-27 00:24:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not highlight large code blocks (#10125)

Browse Source
This commit is contained in:
Bianca Nenciu 2020-07-07 18:51:19 +03:00 committed by GitHub
parent 6705c45156
commit 4a90464619
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse/app/lib/highlight-syntax.js
View File

@ -14,6 +14,11 @@ export default function highlightSyntax($elem) {
} }
$(selector, $elem).each(function(i, e) { $(selector, $elem).each(function(i, e) {
// Large code blocks can cause crashes or slowdowns
if (e.innerHTML.length > 30000) {
return;
}
$(e).removeClass("lang-auto"); $(e).removeClass("lang-auto");
loadScript(path).then(() => { loadScript(path).then(() => {
customHighlightJSLanguages(); customHighlightJSLanguages();

21
test/javascripts/components/highlighted-code-test.js
View File

@ -1,5 +1,7 @@
import componentTest from "helpers/component-test"; import componentTest from "helpers/component-test";
const LONG_CODE_BLOCK = "puts a\n".repeat(15000);
moduleForComponent("highlighted-code", { integration: true }); moduleForComponent("highlighted-code", { integration: true });
componentTest("highlighting code", { componentTest("highlighting code", {
@ -20,3 +22,22 @@ componentTest("highlighting code", {
); );
} }
}); });
componentTest("large code blocks are not highlighted", {
template: "{{highlighted-code lang='ruby' code=code}}",
beforeEach() {
Discourse.HighlightJSPath =
"assets/highlightjs/highlight-test-bundle.min.js";
this.set("code", LONG_CODE_BLOCK);
},
async test(assert) {
assert.equal(
find("code")
.text()
.trim(),
LONG_CODE_BLOCK.trim()
);
}
});