github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 23:21:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: remove alias from chat direct message channel titles (#28958)

Browse Source 
Makes usernames in Chat Direct Message channels consistent with other areas of the app by removing the alias.
This commit is contained in:
David Battersby
2024-09-18 22:18:46 +04:00
committed by GitHub
parent 05b8ff436c
commit 4bfe78d1e6
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/spec/models/chat/direct_message_spec.rb
View File

@ -19,7 +19,7 @@ describe Chat::DirectMessage do
I18n.t(
"chat.channel.dm_title.multi_user",
comma_separated_usernames:
[user3, user2].map { |u| "@#{u.username}" }.join(I18n.t("word_connector.comma")),
[user3, user2].map { |u| u.username }.join(I18n.t("word_connector.comma")),
),
)
end
@ -38,7 +38,7 @@ describe Chat::DirectMessage do
comma_separated_usernames:
users[1..6]
.sort_by(&:username)
.map { |u| "@#{u.username}" }
.map { |u| u.username }
.join(I18n.t("word_connector.comma")),
count: 2,
),
@ -49,7 +49,7 @@ describe Chat::DirectMessage do
direct_message = Fabricate(:direct_message, users: [user1, user2])
expect(direct_message.chat_channel_title_for_user(chat_channel, user1)).to eq(
I18n.t("chat.channel.dm_title.single_user", username: "@#{user2.username}"),
I18n.t("chat.channel.dm_title.single_user", username: user2.username),
)
end
@ -57,7 +57,7 @@ describe Chat::DirectMessage do
direct_message = Fabricate(:direct_message, users: [user1])
expect(direct_message.chat_channel_title_for_user(chat_channel, user1)).to eq(
I18n.t("chat.channel.dm_title.single_user", username: "@#{user1.username}"),
I18n.t("chat.channel.dm_title.single_user", username: user1.username),
)
end
@ -68,7 +68,7 @@ describe Chat::DirectMessage do
direct_message.reload
expect(direct_message.chat_channel_title_for_user(chat_channel, user1)).to eq(
"@#{I18n.t("chat.deleted_chat_username")}",
I18n.t("chat.deleted_chat_username"),
)
end
end
@ -112,7 +112,7 @@ describe Chat::DirectMessage do
expect(direct_message.chat_channel_title_for_user(chat_channel, user1)).to eq(
I18n.t(
"chat.channel.dm_title.multi_user",
comma_separated_usernames: ["@#{user2.username}", new_user.name].join(
comma_separated_usernames: [user2.username, new_user.name].join(
I18n.t("word_connector.comma"),
),
),