github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:11:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Prefer throwing a new Error object instead of just a string expression

Browse Source
This commit is contained in:
kleinfreund
2018-06-05 16:43:45 +02:00
committed by Sam
parent 0997eb6486
commit 4ce1d230c7
19 changed files with 35 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/javascripts/helpers/select-kit-helper.js
View File

@ -1,12 +1,12 @@
function checkSelectKitIsNotExpanded(selector) {
if (find(selector).hasClass('is-expanded')) {
throw 'You expected select-kit to be collapsed but it is expanded.';
throw new Error('You expected select-kit to be collapsed but it is expanded.');
}
}
function checkSelectKitIsNotCollapsed(selector) {
if (!find(selector).hasClass('is-expanded')) {
throw 'You expected select-kit to be expanded but it is collapsed.';
throw new Error('You expected select-kit to be expanded but it is collapsed.');
}
}