github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Remove double escaped Vimeo titles (#21368)

Browse Source 
og_data is already escaped
This commit is contained in:
Jan Cernik
2023-05-04 07:54:00 -03:00
committed by GitHub
parent 0424eb8db2
commit 4e0563a8fe
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/discourse-lazy-videos/lib/lazy-videos/lazy_vimeo.rb
View File

@ -19,18 +19,15 @@ class Onebox::Engine::VimeoOnebox
iframe_id = iframe_src.sub("https://player.vimeo.com/video/", "") iframe_id = iframe_src.sub("https://player.vimeo.com/video/", "")
end end
thumbnail_url = get_opengraph.image
escaped_title = ERB::Util.html_escape(og_data.title)
<<~HTML <<~HTML
<div class="vimeo-onebox lazy-video-container" <div class="vimeo-onebox lazy-video-container"
data-video-id="#{iframe_id}" data-video-id="#{iframe_id}"
data-video-title="#{escaped_title}" data-video-title="#{og_data.title}"
data-provider-name="vimeo"> data-provider-name="vimeo">
<a href="https://vimeo.com/#{full_video_id}" target="_blank"> <a href="https://vimeo.com/#{full_video_id}" target="_blank">
<img class="vimeo-thumbnail" <img class="vimeo-thumbnail"
src="#{thumbnail_url}" src="#{og_data.image}"
title="#{escaped_title}"> title="#{og_data.title}">
</a> </a>
</div> </div>
HTML HTML