FIX: Wrong argument error being thrown in UrlHelper (#24506)

We were throwing ArgumentError in UrlHelper.normalised_encode,
but it was incorrect -- we were passing ArgumentError.new
2 arguments which is not supported. Fix this and have a hint
of which URL is causing the issue for debugging.
This commit is contained in:
Martin Brennan
2023-11-22 15:19:40 +10:00
committed by GitHub
parent 86da47f58d
commit 4e7929abb6
2 changed files with 6 additions and 2 deletions

View File

@ -166,8 +166,10 @@ RSpec.describe UrlHelper do
end
it "raises error if too long" do
expect do UrlHelper.normalized_encode("https://#{"a" * 2_000}.com") end.to raise_error(
long_url = "https://#{"a" * 2_000}.com"
expect do UrlHelper.normalized_encode(long_url) end.to raise_error(
ArgumentError,
"URL starting with #{long_url[0..100]} is too long",
)
end
end