mirror of
https://github.com/discourse/discourse.git
synced 2025-05-22 22:21:04 +08:00
DEV: Single admin plugin page for consistent admin plugin UX (#26024)
This commit adds new plugin show routes (`/admin/plugins/:plugin_id`) as we move towards every plugin having a consistent UI/landing page. As part of this, we are introducing a consistent way for plugins to show an inner sidebar in their config page, via a new plugin API `register_admin_config_nav_routes` This accepts an array of links with a label/text, and an ember route. Once this commit is merged we can start the process of conforming other plugins to follow this pattern, as well as supporting a single-page version of this for simpler plugins that don't require an inner sidebar. Part of /t/122841 internally
This commit is contained in:
@ -999,4 +999,30 @@ TEXT
|
||||
expect(sum).to eq(3)
|
||||
end
|
||||
end
|
||||
|
||||
describe "#register_admin_config_nav_routes" do
|
||||
let(:plugin) { Plugin::Instance.new }
|
||||
|
||||
it "adds the specified plugin id as the 'model' for the route" do
|
||||
plugin.register_admin_config_nav_routes(
|
||||
"discourse-awesome",
|
||||
[{ route: "adminPlugins.show", label: "some.i18n.label" }],
|
||||
)
|
||||
expect(plugin.admin_config_nav_routes).to eq(
|
||||
[{ route: "adminPlugins.show", label: "some.i18n.label", model: "discourse-awesome" }],
|
||||
)
|
||||
end
|
||||
|
||||
it "errors if the route or label is not provided" do
|
||||
expect {
|
||||
plugin.register_admin_config_nav_routes("discourse-awesome", [{ label: "some.i18n.label" }])
|
||||
}.to raise_error(ArgumentError)
|
||||
expect {
|
||||
plugin.register_admin_config_nav_routes(
|
||||
"discourse-awesome",
|
||||
[{ route: "adminPlugins.show" }],
|
||||
)
|
||||
}.to raise_error(ArgumentError)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user