Add rubocop to our build. (#5004)

This commit is contained in:
Guo Xiang Tan
2017-07-28 10:20:09 +09:00
committed by GitHub
parent ff4e295c4f
commit 5012d46cbd
871 changed files with 5480 additions and 6056 deletions

View File

@ -42,13 +42,13 @@ module Scheduler
def keep_alive
@manager.keep_alive
rescue => ex
Discourse.handle_job_exception(ex, {message: "Scheduling manager keep-alive"})
Discourse.handle_job_exception(ex, message: "Scheduling manager keep-alive")
end
def reschedule_orphans
@manager.reschedule_orphans!
rescue => ex
Discourse.handle_job_exception(ex, {message: "Scheduling manager orphan rescheduler"})
Discourse.handle_job_exception(ex, message: "Scheduling manager orphan rescheduler")
end
def hostname
@ -117,7 +117,7 @@ module Scheduler
@mutex.synchronize { info.write! }
end
rescue => ex
Discourse.handle_job_exception(ex, {message: "Processing scheduled job queue"})
Discourse.handle_job_exception(ex, message: "Processing scheduled job queue")
ensure
@running = false
ActiveRecord::Base.connection_handler.clear_active_connections!
@ -175,11 +175,11 @@ module Scheduler
end
def self.without_runner(redis=nil)
def self.without_runner(redis = nil)
self.new(redis, skip_runner: true)
end
def initialize(redis = nil, options=nil)
def initialize(redis = nil, options = nil)
@redis = $redis || redis
@random_ratio = 0.1
unless options && options[:skip_runner]
@ -236,7 +236,7 @@ module Scheduler
end
end
def reschedule_orphans_on!(hostname=nil)
def reschedule_orphans_on!(hostname = nil)
redis.zrange(Manager.queue_key(hostname), 0, -1).each do |key|
klass = get_klass(key)
next unless klass
@ -264,7 +264,7 @@ module Scheduler
end
end
def schedule_next_job(hostname=nil)
def schedule_next_job(hostname = nil)
(key, due), _ = redis.zrange Manager.queue_key(hostname), 0, 0, withscores: true
return unless key
@ -310,7 +310,6 @@ module Scheduler
end
end
def self.discover_schedules
# hack for developemnt reloader is crazytown
# multiple classes with same name can be in
@ -343,7 +342,7 @@ module Scheduler
"_scheduler_lock_"
end
def self.queue_key(hostname=nil)
def self.queue_key(hostname = nil)
if hostname
"_scheduler_queue_#{hostname}_"
else
@ -351,7 +350,7 @@ module Scheduler
end
end
def self.schedule_key(klass,hostname=nil)
def self.schedule_key(klass, hostname = nil)
if hostname
"_scheduler_#{klass}_#{hostname}"
else