Add rubocop to our build. (#5004)

This commit is contained in:
Guo Xiang Tan
2017-07-28 10:20:09 +09:00
committed by GitHub
parent ff4e295c4f
commit 5012d46cbd
871 changed files with 5480 additions and 6056 deletions

View File

@ -101,7 +101,7 @@ module DiscourseNarrativeBot
def reset_bot(user, post)
if pm_to_bot?(post)
reset_data(user, { topic_id: post.topic_id })
reset_data(user, topic_id: post.topic_id)
else
reset_data(user)
end
@ -116,15 +116,13 @@ module DiscourseNarrativeBot
fake_delay
post = PostCreator.create!(@user, {
raw: I18n.t(
post = PostCreator.create!(@user, raw: I18n.t(
"#{I18N_KEY}.edit.bot_created_post_raw",
i18n_post_args(discobot_username: self.discobot_user.username)
),
topic_id: data[:topic_id],
skip_bot: true,
skip_validations: true
})
topic_id: data[:topic_id],
skip_bot: true,
skip_validations: true)
set_state_data(:post_id, post.id)
post
@ -133,15 +131,13 @@ module DiscourseNarrativeBot
def init_tutorial_recover
data = get_data(@user)
post = PostCreator.create!(@user, {
raw: I18n.t(
post = PostCreator.create!(@user, raw: I18n.t(
"#{I18N_KEY}.recover.deleted_post_raw",
i18n_post_args(discobot_username: self.discobot_user.username)
),
topic_id: data[:topic_id],
skip_bot: true,
skip_validations: true
})
topic_id: data[:topic_id],
skip_bot: true,
skip_validations: true)
set_state_data(:post_id, post.id)

View File

@ -109,7 +109,7 @@ module DiscourseNarrativeBot
skip_trigger: TrackSelector.skip_trigger,
reset_trigger: "#{TrackSelector.reset_trigger} #{self.class.reset_trigger}"
)
), {}, { skip_send_email: false })
), {}, skip_send_email: false)
end
end
@ -168,8 +168,8 @@ module DiscourseNarrativeBot
end
end
def i18n_post_args(extra={})
{base_uri: Discourse.base_uri}.merge(extra)
def i18n_post_args(extra = {})
{ base_uri: Discourse.base_uri }.merge(extra)
end
def valid_topic?(topic_id)

View File

@ -121,7 +121,7 @@ module DiscourseNarrativeBot
def reset_bot(user, post)
if pm_to_bot?(post)
reset_data(user, { topic_id: post.topic_id })
reset_data(user, topic_id: post.topic_id)
else
reset_data(user)
end
@ -154,7 +154,7 @@ module DiscourseNarrativeBot
PostRevisor.new(post, topic).revise!(
self.discobot_user,
{ raw: raw },
{ skip_validations: true, force_new_version: true }
skip_validations: true, force_new_version: true
)
set_state_data(:post_version, post.reload.version || 0)