Add rubocop to our build. (#5004)

spec/components/admin_user_index_query_spec.rb

@@ -13,32 +13,32 @@ describe AdminUserIndexQuery do
     end
 
     it "has active order" do
-      query = ::AdminUserIndexQuery.new({ query: "active" })
+      query = ::AdminUserIndexQuery.new(query: "active")
       expect(query.find_users_query.to_sql).to match("last_seen_at")
     end
 
     it "can't be injected" do
-      query = ::AdminUserIndexQuery.new({ order: "wat, no" })
+      query = ::AdminUserIndexQuery.new(order: "wat, no")
       expect(query.find_users_query.to_sql).not_to match("wat, no")
     end
 
     it "allows custom ordering" do
-      query = ::AdminUserIndexQuery.new({ order: "trust_level" })
+      query = ::AdminUserIndexQuery.new(order: "trust_level")
       expect(query.find_users_query.to_sql).to match("trust_level DESC")
     end
 
     it "allows custom ordering asc" do
-      query = ::AdminUserIndexQuery.new({ order: "trust_level", ascending: true })
-      expect(query.find_users_query.to_sql).to match("trust_level ASC" )
+      query = ::AdminUserIndexQuery.new(order: "trust_level", ascending: true)
+      expect(query.find_users_query.to_sql).to match("trust_level ASC")
     end
 
     it "allows custom ordering for stats wtih default direction" do
-      query = ::AdminUserIndexQuery.new({ order: "topics_viewed" })
+      query = ::AdminUserIndexQuery.new(order: "topics_viewed")
       expect(query.find_users_query.to_sql).to match("topics_entered DESC")
     end
 
     it "allows custom ordering and direction for stats" do
-      query = ::AdminUserIndexQuery.new({ order: "topics_viewed", ascending: true })
+      query = ::AdminUserIndexQuery.new(order: "topics_viewed", ascending: true)
       expect(query.find_users_query.to_sql).to match("topics_entered ASC")
     end
   end
@@ -50,17 +50,17 @@ describe AdminUserIndexQuery do
     end
 
     it "offsets by 100 by default for page 2" do
-      query = ::AdminUserIndexQuery.new({ page: "2"})
+      query = ::AdminUserIndexQuery.new(page: "2")
       expect(query.find_users.to_sql).to match("OFFSET 100")
     end
 
     it "offsets by limit for page 2" do
-      query = ::AdminUserIndexQuery.new({ page: "2"})
+      query = ::AdminUserIndexQuery.new(page: "2")
       expect(query.find_users(10).to_sql).to match("OFFSET 10")
     end
 
     it "ignores negative pages" do
-      query = ::AdminUserIndexQuery.new({ page: "-2" })
+      query = ::AdminUserIndexQuery.new(page: "-2")
       expect(query.find_users.to_sql).to match("OFFSET 0")
     end
   end
@@ -69,7 +69,7 @@ describe AdminUserIndexQuery do
 
     TrustLevel.levels.each do |key, value|
       it "#{key} returns no records" do
-        query = ::AdminUserIndexQuery.new({ query: key.to_s })
+        query = ::AdminUserIndexQuery.new(query: key.to_s)
         expect(real_users_count(query)).to eq(0)
       end
     end
@@ -81,7 +81,7 @@ describe AdminUserIndexQuery do
     TrustLevel.levels.each do |key, value|
       it "finds user with trust #{key}" do
         Fabricate(:user, trust_level: TrustLevel.levels[key])
-        query = ::AdminUserIndexQuery.new({ query: key.to_s })
+        query = ::AdminUserIndexQuery.new(query: key.to_s)
         expect(real_users_count(query)).to eq(1)
       end
     end
@@ -93,14 +93,14 @@ describe AdminUserIndexQuery do
     let!(:user) { Fabricate(:user, approved: false) }
 
     it "finds the unapproved user" do
-      query = ::AdminUserIndexQuery.new({ query: 'pending' })
+      query = ::AdminUserIndexQuery.new(query: 'pending')
       expect(query.find_users.count).to eq(1)
     end
 
     context 'and a suspended pending user' do
       let!(:suspended_user) { Fabricate(:user, approved: false, suspended_at: 1.hour.ago, suspended_till: 20.years.from_now) }
       it "doesn't return the suspended user" do
-        query = ::AdminUserIndexQuery.new({ query: 'pending' })
+        query = ::AdminUserIndexQuery.new(query: 'pending')
         expect(query.find_users.count).to eq(1)
       end
     end
@@ -113,7 +113,7 @@ describe AdminUserIndexQuery do
     end
 
     it "shows nil values first with asc" do
-      users = ::AdminUserIndexQuery.new({ order: "last_emailed", ascending: true }).find_users
+      users = ::AdminUserIndexQuery.new(order: "last_emailed", ascending: true).find_users
 
       expect(users.where('users.id > -2').count).to eq(2)
       expect(users.first.username).to eq("system")
@@ -121,7 +121,7 @@ describe AdminUserIndexQuery do
     end
 
     it "shows nil values last with desc" do
-      users = ::AdminUserIndexQuery.new({ order: "last_emailed"}).find_users
+      users = ::AdminUserIndexQuery.new(order: "last_emailed").find_users
 
       expect(users.where('users.id > -2').count).to eq(2)
       expect(users.first.last_emailed_at).to_not eq(nil)
@@ -134,7 +134,7 @@ describe AdminUserIndexQuery do
     let!(:user) { Fabricate(:user, admin: true) }
 
     it "finds the admin" do
-      query = ::AdminUserIndexQuery.new({ query: 'admins' })
+      query = ::AdminUserIndexQuery.new(query: 'admins')
       expect(real_users_count(query)).to eq(1)
     end
 
@@ -145,7 +145,7 @@ describe AdminUserIndexQuery do
     let!(:user) { Fabricate(:user, moderator: true) }
 
     it "finds the moderator" do
-      query = ::AdminUserIndexQuery.new({ query: 'moderators' })
+      query = ::AdminUserIndexQuery.new(query: 'moderators')
       expect(real_users_count(query)).to eq(1)
     end
 
@@ -156,7 +156,7 @@ describe AdminUserIndexQuery do
     let!(:user) { Fabricate(:user, blocked: true) }
 
     it "finds the blocked user" do
-      query = ::AdminUserIndexQuery.new({ query: 'blocked' })
+      query = ::AdminUserIndexQuery.new(query: 'blocked')
       expect(query.find_users.count).to eq(1)
     end
 
@@ -169,12 +169,12 @@ describe AdminUserIndexQuery do
       before(:each) { Fabricate(:user, email: "test1@example.com") }
 
       it "matches the email" do
-        query = ::AdminUserIndexQuery.new({ filter: " est1" })
+        query = ::AdminUserIndexQuery.new(filter: " est1")
         expect(query.find_users.count()).to eq(1)
       end
 
       it "matches the email using any case" do
-        query = ::AdminUserIndexQuery.new({ filter: "Test1\t" })
+        query = ::AdminUserIndexQuery.new(filter: "Test1\t")
         expect(query.find_users.count()).to eq(1)
       end
 
@@ -185,12 +185,12 @@ describe AdminUserIndexQuery do
       before(:each) { Fabricate(:user, username: "test_user_1") }
 
       it "matches the username" do
-        query = ::AdminUserIndexQuery.new({ filter: "user\n" })
+        query = ::AdminUserIndexQuery.new(filter: "user\n")
         expect(query.find_users.count).to eq(1)
       end
 
       it "matches the username using any case" do
-        query = ::AdminUserIndexQuery.new({ filter: "\r\nUser" })
+        query = ::AdminUserIndexQuery.new(filter: "\r\nUser")
         expect(query.find_users.count).to eq(1)
       end
     end
@@ -200,7 +200,7 @@ describe AdminUserIndexQuery do
       let!(:user) { Fabricate(:user, ip_address: "117.207.94.9") }
 
       it "matches the ip address" do
-        query = ::AdminUserIndexQuery.new({ filter: " 117.207.94.9 " })
+        query = ::AdminUserIndexQuery.new(filter: " 117.207.94.9 ")
         expect(query.find_users.count()).to eq(1)
       end