github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 06:17:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: 🐛 Saving the same custom field array twice would raise an error

Browse Source
This commit is contained in:
Robin Ward
2015-01-15 15:31:31 -05:00
parent 3ab2f105b4
commit 505fa9f1cf
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/concerns/has_custom_fields.rb
View File

@ -117,7 +117,7 @@ module HasCustomFields
array_fields.each do |field_name, fields| array_fields.each do |field_name, fields|
if fields.length == dup[field_name].length && if fields.length == dup[field_name].length &&
fields.map{|f| f.value} == dup[field_name] fields.map{|f| f.value} == dup[field_name]
dup.delete(f.name) dup.delete(field_name)
else else
fields.each{|f| f.destroy } fields.each{|f| f.destroy }
end end

8
spec/components/concern/has_custom_fields_spec.rb
View File

@ -115,6 +115,14 @@ describe HasCustomFields do
db_item.save db_item.save
expect(db_item.custom_fields).to eq({"a" => ["c", "d"]}) expect(db_item.custom_fields).to eq({"a" => ["c", "d"]})
# It can be updated to the exact same value
db_item.custom_fields.update('a' => ['c'])
db_item.save
expect(db_item.custom_fields).to eq({"a" => "c"})
db_item.custom_fields.update('a' => ['c'])
db_item.save
expect(db_item.custom_fields).to eq({"a" => "c"})
db_item.custom_fields.delete('a') db_item.custom_fields.delete('a')
expect(db_item.custom_fields).to eq({}) expect(db_item.custom_fields).to eq({})