mirror of
https://github.com/discourse/discourse.git
synced 2025-05-21 18:12:32 +08:00
Adds better reusable error message support. Added to fetching remote
posts. /cc @riking
This commit is contained in:
55
spec/components/json_error_spec.rb
Normal file
55
spec/components/json_error_spec.rb
Normal file
@ -0,0 +1,55 @@
|
||||
require 'spec_helper'
|
||||
require_dependency 'json_error'
|
||||
|
||||
shared_examples "a generic error" do
|
||||
let(:result) { creator.create_errors_json(obj) }
|
||||
|
||||
it "should have a result object" do
|
||||
result.should be_present
|
||||
end
|
||||
|
||||
it "has a generic error message" do
|
||||
result[:errors].should == [I18n.t('js.generic_error')]
|
||||
end
|
||||
end
|
||||
|
||||
describe JsonError do
|
||||
|
||||
let(:creator) { Object.new.extend(JsonError) }
|
||||
|
||||
describe "with a nil argument" do
|
||||
it_behaves_like "a generic error" do
|
||||
let(:obj) { nil }
|
||||
end
|
||||
end
|
||||
|
||||
describe "with an empty array" do
|
||||
it_behaves_like "a generic error" do
|
||||
let(:obj) { [] }
|
||||
end
|
||||
end
|
||||
|
||||
describe "with an activerecord object with no errors" do
|
||||
it_behaves_like "a generic error" do
|
||||
let(:obj) { Fabricate.build(:user) }
|
||||
end
|
||||
end
|
||||
|
||||
describe "with a string" do
|
||||
it "returns the string in the error format" do
|
||||
creator.create_errors_json("test error").should == {errors: ["test error"]}
|
||||
end
|
||||
end
|
||||
|
||||
describe "an activerecord objec with errors" do
|
||||
let(:invalid_user) { User.new }
|
||||
it "returns the errors correctly" do
|
||||
invalid_user.should_not be_valid
|
||||
result = creator.create_errors_json(invalid_user)
|
||||
result.should be_present
|
||||
result[:errors].should_not be_blank
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
Reference in New Issue
Block a user