github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 13:51:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove full group refreshes from tests (#25414)

Browse Source 
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this:

You have fabricated a user that needs a certain trust level (which is now based on group membership.)
You need the system user to have a certain trust level.
In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups.

The second case is no longer a thing after #25400.
This commit is contained in:
Ted Johansson
2024-01-25 14:28:26 +08:00
committed by GitHub
parent 74fd883a89
commit 57ea56ee05
64 changed files with 131 additions and 269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/integration/category_tag_spec.rb
View File

@ -793,10 +793,9 @@ RSpec.describe "tag topic counts per category" do
end
context "with topic with 2 tags" do
fab!(:topic) { Fabricate(:topic, category: category, tags: [tag1, tag2]) }
fab!(:post) { Fabricate(:post, user: topic.user, topic: topic) }
before { Group.refresh_automatic_groups! }
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
fab!(:topic) { Fabricate(:topic, user: user, category: category, tags: [tag1, tag2]) }
fab!(:post) { Fabricate(:post, user: user, topic: topic) }
it "has correct counts after tag is removed from a topic" do
post
@ -837,14 +836,13 @@ RSpec.describe "tag topic counts per category" do
end
context "with topic with one tag" do
fab!(:topic) { Fabricate(:topic, tags: [tag1], category: category) }
fab!(:post) { Fabricate(:post, user: topic.user, topic: topic) }
before { Group.refresh_automatic_groups! }
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
fab!(:topic) { Fabricate(:topic, user: user, tags: [tag1], category: category) }
fab!(:post) { Fabricate(:post, user: user, topic: topic) }
it "counts after topic becomes uncategorized" do
PostRevisor.new(post).revise!(
topic.user,
user,
raw: post.raw,
tags: [tag1.name],
category_id: SiteSetting.uncategorized_category_id,

1
spec/integration/watched_words_spec.rb
View File

@ -187,7 +187,6 @@ RSpec.describe WatchedWord do
end
it "doesn't need approval in a private message" do
Group.refresh_automatic_groups!
manager =
NewPostManager.new(
tl2_user,