github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 02:54:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove full group refreshes from tests (#25414)

Browse Source 
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this:

You have fabricated a user that needs a certain trust level (which is now based on group membership.)
You need the system user to have a certain trust level.
In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups.

The second case is no longer a thing after #25400.
This commit is contained in:
Ted Johansson
2024-01-25 14:28:26 +08:00
committed by GitHub
parent 74fd883a89
commit 57ea56ee05
64 changed files with 131 additions and 269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/lib/guardian/topic_guardian_spec.rb
View File

@ -1,9 +1,9 @@
# frozen_string_literal: true
RSpec.describe TopicGuardian do
fab!(:user)
fab!(:admin)
fab!(:tl3_user) { Fabricate(:trust_level_3) }
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
fab!(:admin) { Fabricate(:admin, refresh_auto_groups: true) }
fab!(:tl3_user) { Fabricate(:trust_level_3, refresh_auto_groups: true) }
fab!(:tl4_user) { Fabricate(:trust_level_4, refresh_auto_groups: true) }
fab!(:moderator)
fab!(:category)
@ -18,8 +18,6 @@ RSpec.describe TopicGuardian do
after { Guardian.disable_topic_can_see_consistency_check }
describe "#can_create_shared_draft?" do
before { Group.refresh_automatic_groups! }
it "when shared_drafts are disabled" do
SiteSetting.shared_drafts_allowed_groups = Group::AUTO_GROUPS[:admins]
@ -49,8 +47,6 @@ RSpec.describe TopicGuardian do
end
describe "#can_see_shared_draft?" do
before { Group.refresh_automatic_groups! }
it "when shared_drafts are disabled (existing shared drafts)" do
SiteSetting.shared_drafts_allowed_groups = Group::AUTO_GROUPS[:admins]