github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 20:41:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove full group refreshes from tests (#25414)

Browse Source 
We have all these calls to Group.refresh_automatic_groups! littered throughout the tests. Including tests that are seemingly unrelated to groups. This is because automatic group memberships aren't fabricated when making a vanilla user. There are two places where you'd want to use this:

You have fabricated a user that needs a certain trust level (which is now based on group membership.)
You need the system user to have a certain trust level.
In the first case, we can pass refresh_auto_groups: true to the fabricator instead. This is a more lightweight operation that only considers a single user, instead of all users in all groups.

The second case is no longer a thing after #25400.
This commit is contained in:
Ted Johansson
2024-01-25 14:28:26 +08:00
committed by GitHub
parent 74fd883a89
commit 57ea56ee05
64 changed files with 131 additions and 269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/models/user_spec.rb
View File

@ -1760,7 +1760,7 @@ RSpec.describe User do
end
describe "#purge_unactivated" do
fab!(:user)
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
fab!(:unactivated) { Fabricate(:user, active: false) }
fab!(:unactivated_old) { Fabricate(:user, active: false, created_at: 1.month.ago) }
fab!(:unactivated_old_with_system_pm) do
@ -1769,11 +1769,11 @@ RSpec.describe User do
fab!(:unactivated_old_with_human_pm) do
Fabricate(:user, active: false, created_at: 2.months.ago)
end
fab!(:unactivated_old_with_post) { Fabricate(:user, active: false, created_at: 1.month.ago) }
fab!(:unactivated_old_with_post) do
Fabricate(:user, active: false, created_at: 1.month.ago, refresh_auto_groups: true)
end
before do
Group.refresh_automatic_groups!
PostCreator.new(
Discourse.system_user,
title: "Welcome to our Discourse",