github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 00:33:31 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactor admin base controller (#18453)

Browse Source 
* DEV: Add a dedicated Admin::StaffController base controller

The current parent(Admin:AdminController) for all admin-related controllers
uses a filter that allows only staff(admin, moderator) users.

This refactor makes Admin::AdminController filter for only admins as the name suggests and
introduces a base controller dedicated for staff-related endpoints.

* DEV: Set staff-only controllers parent to Admin::StaffController

Refactor staff-only controllers to inherit newly introduced
Admin::StaffController abstract controller. This conveys the
purpose of the parent controller better unlike the previously used parent
controller.
This commit is contained in:
Selase Krakani
2022-10-31 12:02:26 +00:00
committed by GitHub
parent 5e4bad0d8f
commit 586454bcf1
30 changed files with 190 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/requests/admin/email_styles_controller_spec.rb
View File

@ -14,6 +14,10 @@ RSpec.describe Admin::EmailStylesController do
SiteSetting.remove_override!(:email_custom_css)
end
it "is a subclass of AdminController" do
expect(Admin::EmailStylesController < Admin::AdminController).to eq(true)
end
describe 'show' do
it 'returns default values' do
get '/admin/customize/email_style.json'