Refactor Users#upload_avatar method

Moved avatar file upload to ```AvatarUploadService``` class and
```AvatarUploadPolicy```

Address review comments + require missing file in spec
This commit is contained in:
railsaholic
2013-11-11 23:21:14 +05:30
parent 20f06f3efc
commit 58f78e9001
4 changed files with 148 additions and 36 deletions

View File

@ -996,7 +996,7 @@ describe UsersController do
end
it 'rejects large images' do
SiteSetting.stubs(:max_image_size_kb).returns(1)
AvatarUploadPolicy.any_instance.stubs(:too_big?).returns(true)
xhr :post, :upload_avatar, username: user.username, file: avatar
response.status.should eq 413
end
@ -1041,7 +1041,7 @@ describe UsersController do
end
it 'rejects large images' do
SiteSetting.stubs(:max_image_size_kb).returns(1)
AvatarUploadPolicy.any_instance.stubs(:too_big?).returns(true)
xhr :post, :upload_avatar, username: user.username, file: avatar_url
response.status.should eq 413
end