github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-02 02:05:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Avoid $ globals (#15453)

Browse Source 
Also:
* Remove an unused method (#fill_email)
* Replace a method that was used just once (#generate_username) with `SecureRandom.alphanumeric`
* Remove an obsolete dev puma `tmp/restart` file logic
This commit is contained in:
Jarek Radosz
2022-01-08 23:39:46 +01:00
committed by GitHub
parent c0d72ec3d6
commit 5a50f18c0c
14 changed files with 32 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/requests/users_controller_spec.rb
View File

@ -1610,13 +1610,13 @@ describe UsersController do
context 'is too long' do
before do
get "/u/check_username.json", params: { username: generate_username(User.username_length.last + 1) }
get "/u/check_username.json", params: { username: SecureRandom.alphanumeric(SiteSetting.max_username_length.to_i + 1) }
end
include_examples 'checking an invalid username'
it 'should return the "too long" message' do
expect(response.status).to eq(200)
expect(response.parsed_body['errors']).to include(I18n.t(:'user.username.long', max: User.username_length.end))
expect(response.parsed_body['errors']).to include(I18n.t(:'user.username.long', max: SiteSetting.max_username_length))
end
end