github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 00:37:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not raise an error when in:all search is performed by anon (#9113)

Browse Source 
Also improve in:all specs to catch to catch similar failures
This commit is contained in:
David Taylor
2020-03-05 17:50:29 +00:00
committed by GitHub
parent 4b70719a48
commit 5b3630dba3
2 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
spec/components/search_spec.rb
View File

@ -315,56 +315,53 @@ describe Search do
TopicAllowedUser.create!(user_id: u2.id, topic_id: private_topic.id)
# private only
results = Search.execute('cheese',
type_filter: 'all_topics',
results = Search.execute('in:all cheese',
guardian: Guardian.new(u1))
expect(results.posts.length).to eq(1)
# public only
results = Search.execute('eggs',
type_filter: 'all_topics',
results = Search.execute('in:all eggs',
guardian: Guardian.new(u1))
expect(results.posts.length).to eq(1)
# both
results = Search.execute('spam',
type_filter: 'all_topics',
results = Search.execute('in:all spam',
guardian: Guardian.new(u1))
expect(results.posts.length).to eq(2)
# for anon
results = Search.execute('in:all spam',
guardian: Guardian.new)
expect(results.posts.length).to eq(1)
# nonparticipatory user
results = Search.execute('cheese',
type_filter: 'all_topics',
results = Search.execute('in:all cheese',
guardian: Guardian.new(u3))
expect(results.posts.length).to eq(0)
results = Search.execute('eggs',
type_filter: 'all_topics',
results = Search.execute('in:all eggs',
guardian: Guardian.new(u3))
expect(results.posts.length).to eq(1)
results = Search.execute('spam',
type_filter: 'all_topics',
results = Search.execute('in:all spam',
guardian: Guardian.new(u3))
expect(results.posts.length).to eq(1)
# Admin doesn't see private topic
results = Search.execute('spam',
type_filter: 'all_topics',
results = Search.execute('in:all spam',
guardian: Guardian.new(u4))
expect(results.posts.length).to eq(1)
# same keyword for different users
results = Search.execute('ham',
type_filter: 'all_topics',
results = Search.execute('in:all ham',
guardian: Guardian.new(u1))
expect(results.posts.length).to eq(2)
results = Search.execute('ham',
type_filter: 'all_topics',
results = Search.execute('in:all ham',
guardian: Guardian.new(u2))
expect(results.posts.length).to eq(2)
results = Search.execute('ham',
type_filter: 'all_topics',
results = Search.execute('in:all ham',
guardian: Guardian.new(u3))
expect(results.posts.length).to eq(1)
end