Refactors PostsController and adds unit tests.

This commit is contained in:
Wojciech Zawistowski
2014-02-18 17:19:38 +01:00
parent 6c23a1903e
commit 5b9a4d3581
2 changed files with 26 additions and 2 deletions

View File

@ -64,7 +64,7 @@ class PostsController < ApplicationController
post = post.first
post.image_sizes = params[:image_sizes] if params[:image_sizes].present?
if !guardian.can_edit?(post) && post.user_id == current_user.id && post.edit_time_limit_expired?
if too_late_to(:edit, post)
render json: {errors: [I18n.t('too_late_to_edit')]}, status: 422
return
end
@ -134,7 +134,7 @@ class PostsController < ApplicationController
def destroy
post = find_post_from_params
if !guardian.can_delete_post?(post) && post.user_id == current_user.id && post.edit_time_limit_expired?
if too_late_to(:delete_post, post)
render json: {errors: [I18n.t('too_late_to_edit')]}, status: 422
return
end
@ -269,4 +269,8 @@ class PostsController < ApplicationController
end
end
def too_late_to(action, post)
!guardian.send("can_#{action}?", post) && post.user_id == current_user.id && post.edit_time_limit_expired?
end
end