github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 13:47:47 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Double trigger of close user menu (#30732)

Browse Source 
When clicking the "new features" notification item for
admins that navigates to /whats-new, the user notification
menu was not closing. This was happening because inside
the UserMenu::Menu component, the `routeDidChange` event
was firing and calling `closeUserMenu()`, however this is already
called inside the `Header` component via `toggleHamburger()`.

This is _only_ happening for the "new features" notification
item, other items have already been destroyed and they do not get
the `routeDidChange` event. No idea why, but this fixes the issue
in a global way.
This commit is contained in:
Martin Brennan
2025-01-15 10:38:08 +10:00
committed by GitHub
parent 73b28815e3
commit 5bc522e836
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/chat/spec/system/bookmark_message_spec.rb
View File

@ -73,6 +73,9 @@ RSpec.describe "Bookmark message", type: :system do
expect(channel_page).to have_bookmarked_message(message_1)
user_menu.open
user_menu.click_bookmarks_tab
user_menu.click_bookmark(bookmark_2)
expect(channel_page).to have_bookmarked_message(message_2)