mirror of
https://github.com/discourse/discourse.git
synced 2025-05-29 21:27:58 +08:00
FIX: Double trigger of close user menu (#30732)
When clicking the "new features" notification item for admins that navigates to /whats-new, the user notification menu was not closing. This was happening because inside the UserMenu::Menu component, the `routeDidChange` event was firing and calling `closeUserMenu()`, however this is already called inside the `Header` component via `toggleHamburger()`. This is _only_ happening for the "new features" notification item, other items have already been destroyed and they do not get the `routeDidChange` event. No idea why, but this fixes the issue in a global way.
This commit is contained in:
@ -73,6 +73,9 @@ RSpec.describe "Bookmark message", type: :system do
|
||||
|
||||
expect(channel_page).to have_bookmarked_message(message_1)
|
||||
|
||||
user_menu.open
|
||||
user_menu.click_bookmarks_tab
|
||||
|
||||
user_menu.click_bookmark(bookmark_2)
|
||||
|
||||
expect(channel_page).to have_bookmarked_message(message_2)
|
||||
|
Reference in New Issue
Block a user