github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 06:01:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Revert rails 7.1 upgrade (#27522)

Browse Source 
* Revert "FIX: Set `override_level` on Logster loggers (#27519)"

This reverts commit c1b0488c547bca935de51cfbb86bbc528e9ab2e5.

* Revert "DEV: Make parameters optional to all FakeLogger methods"

This reverts commit 3318dad7b4e3365854319bb55301cf667a2c28d0.

* Revert "FIX: Remove references to `Rails.logger.chained`"

This reverts commit f595d599dd361b7fb39fb3c82cbc11d19d518c19.

* Revert "DEV: Upgrade Rails to 7.1"

This reverts commit 081b00391e47a7f9bc44b9fe8ce88ac97d728352.
This commit is contained in:
Jarek Radosz
2024-06-18 23:48:30 +02:00
committed by GitHub
parent 3fdf279bb2
commit 5cb84f8dcf
47 changed files with 255 additions and 430 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spec/integration/invalid_request_spec.rb
View File

@ -1,11 +1,12 @@
# frozen_string_literal: true
RSpec.describe "invalid requests", type: :request do
let(:fake_logger) { FakeLogger.new }
before do
@orig_logger = Rails.logger
Rails.logger = @fake_logger = FakeLogger.new
end
before { Rails.logger.broadcast_to(fake_logger) }
after { Rails.logger.stop_broadcasting_to(fake_logger) }
after { Rails.logger = @orig_logger }
it "handles NotFound with invalid json body" do
post "/latest.json",
@ -14,8 +15,8 @@ RSpec.describe "invalid requests", type: :request do
"content-type" => "application/json",
}
expect(response.status).to eq(404)
expect(fake_logger.warnings.length).to eq(0)
expect(fake_logger.errors.length).to eq(0)
expect(@fake_logger.warnings.length).to eq(0)
expect(@fake_logger.errors.length).to eq(0)
end
it "handles EOFError when multipart request is malformed" do
@ -26,14 +27,14 @@ RSpec.describe "invalid requests", type: :request do
"content-length" => "1",
}
expect(response.status).to eq(400)
expect(fake_logger.warnings.length).to eq(0)
expect(fake_logger.errors.length).to eq(0)
expect(@fake_logger.warnings.length).to eq(0)
expect(@fake_logger.errors.length).to eq(0)
end
it "handles invalid parameters" do
post "/latest.json", params: { "foo" => "\255bar" }
expect(response.status).to eq(404)
expect(fake_logger.warnings.length).to eq(0)
expect(fake_logger.errors.length).to eq(0)
expect(@fake_logger.warnings.length).to eq(0)
expect(@fake_logger.errors.length).to eq(0)
end
end