github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-05 14:07:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Provide radix argument to parseInt (#8281)

Browse Source 
* DEV: Provide radix 10 argument to parseInt

* DEV: Provide radix 16 argument to parseInt

* DEV: Remove unnecessary parseInt calls

* Fix year formatting

parseInt was used here to convert decimals to ints
This commit is contained in:
Jarek Radosz
2019-11-12 10:47:42 +01:00
committed by GitHub
parent 69266f60ed
commit 5d4b240453
44 changed files with 77 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/javascripts/helpers/create-pretender.js.es6
View File

@ -436,25 +436,25 @@ export default function() {
this.get("/t/:topic_id/posts.json", request => {
const postIds = request.queryParams.post_ids;
const postNumber = parseInt(request.queryParams.post_number);
const postNumber = parseInt(request.queryParams.post_number, 10);
let posts;
if (postIds) {
posts = postIds.map(p => ({
id: parseInt(p),
post_number: parseInt(p)
id: parseInt(p, 10),
post_number: parseInt(p, 10)
}));
} else if (postNumber && request.queryParams.asc === "true") {
posts = _.range(postNumber + 1, postNumber + 6).map(p => ({
id: parseInt(p),
post_number: parseInt(p)
id: parseInt(p, 10),
post_number: parseInt(p, 10)
}));
} else if (postNumber && request.queryParams.asc === "false") {
posts = _.range(postNumber - 5, postNumber)
.reverse()
.map(p => ({
id: parseInt(p),
post_number: parseInt(p)
id: parseInt(p, 10),
post_number: parseInt(p, 10)
}));
}

2
test/javascripts/helpers/review-pretender.js.es6
View File

@ -128,7 +128,7 @@ export default function(helpers) {
return response(200, {
reviewable_perform_result: {
success: true,
remove_reviewable_ids: [parseInt(request.params.id)]
remove_reviewable_ids: [parseInt(request.params.id, 10)]
}
});
});

6
test/javascripts/helpers/store-pretender.js.es6
View File

@ -30,7 +30,7 @@ export default function(helpers) {
const { response, success, parsePostData } = helpers;
this.get("/fruits/:id", function(request) {
const fruit = fruits.find(f => f.id === parseInt(request.params.id));
const fruit = fruits.find(f => f.id === parseInt(request.params.id, 10));
return response({ __rest_serializer: "1", fruit, farmers, colors });
});
@ -58,7 +58,7 @@ export default function(helpers) {
});
this.get("/widgets/:widget_id", function(request) {
const w = _widgets.findBy("id", parseInt(request.params.widget_id));
const w = _widgets.findBy("id", parseInt(request.params.widget_id, 10));
if (w) {
return response({ widget: w, extras: { hello: "world" } });
} else {
@ -91,7 +91,7 @@ export default function(helpers) {
result = result.filterBy("name", qp.name);
}
if (qp.id) {
result = result.filterBy("id", parseInt(qp.id));
result = result.filterBy("id", parseInt(qp.id, 10));
}
}