github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-05 13:16:06 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Autofix (w/ manual follow up) various qunit lints (#29950)

Browse Source
This commit is contained in:
Jarek Radosz
2024-11-27 13:02:55 +01:00
committed by GitHub
parent e4bb727d33
commit 5db0eba0a8
58 changed files with 444 additions and 487 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/test/javascripts/components/chat-composer-upload-test.js
View File

@ -95,7 +95,7 @@ module("Discourse Chat | Component | chat-composer-upload", function (hooks) {
);
await click(".chat-composer-upload__remove-btn");
assert.strictEqual(this.uploadRemoved, true);
assert.true(this.uploadRemoved);
});
test("cancelling in progress upload", async function (assert) {
@ -115,6 +115,6 @@ module("Discourse Chat | Component | chat-composer-upload", function (hooks) {
);
await click(".chat-composer-upload__remove-btn");
assert.strictEqual(this.uploadRemoved, true);
assert.true(this.uploadRemoved);
});
});

6
plugins/chat/test/javascripts/unit/models/chat-message-test.js
View File

@ -10,18 +10,18 @@ module("Discourse Chat | Unit | Models | chat-message", function (hooks) {
test(".persisted", function (assert) {
const channel = new ChatFabricators(getOwner(this)).channel();
let message = ChatMessage.create(channel, { id: null });
assert.strictEqual(message.persisted, false);
assert.false(message.persisted);
message = ChatMessage.create(channel, {
id: 1,
staged: true,
});
assert.strictEqual(message.persisted, false);
assert.false(message.persisted);
message = ChatMessage.create(channel, {
id: 1,
staged: false,
});
assert.strictEqual(message.persisted, true);
assert.true(message.persisted);
});
});

2
plugins/chat/test/javascripts/unit/services/chat-emoji-picker-manager-test.js
View File

@ -62,7 +62,7 @@ module(
await settled();
assert.deepEqual(this.manager.emojis, emojisResponse());
assert.strictEqual(this.manager.loading, false);
assert.false(this.manager.loading);
});
test("closeExisting", async function (assert) {

24
plugins/chat/test/javascripts/unit/services/chat-state-manager-test.js
View File

@ -82,8 +82,8 @@ module(
test("didCollapseDrawer", function (assert) {
this.subject.didCollapseDrawer();
assert.strictEqual(this.subject.isDrawerExpanded, false);
assert.strictEqual(this.subject.isDrawerActive, true);
assert.false(this.subject.isDrawerExpanded);
assert.true(this.subject.isDrawerActive);
});
test("didExpandDrawer", function (assert) {
@ -94,8 +94,8 @@ module(
this.subject.didExpandDrawer();
assert.strictEqual(this.subject.isDrawerExpanded, true);
assert.strictEqual(this.subject.isDrawerActive, true);
assert.true(this.subject.isDrawerExpanded);
assert.true(this.subject.isDrawerActive);
sinon.assert.calledOnce(stub);
});
@ -107,8 +107,8 @@ module(
this.subject.didCloseDrawer();
assert.strictEqual(this.subject.isDrawerExpanded, false);
assert.strictEqual(this.subject.isDrawerActive, false);
assert.false(this.subject.isDrawerExpanded);
assert.false(this.subject.isDrawerActive);
sinon.assert.calledOnce(stub);
});
@ -120,8 +120,8 @@ module(
this.subject.didOpenDrawer();
assert.strictEqual(this.subject.isDrawerExpanded, true);
assert.strictEqual(this.subject.isDrawerActive, true);
assert.true(this.subject.isDrawerExpanded);
assert.true(this.subject.isDrawerActive);
assert.strictEqual(this.subject.lastKnownChatURL, "/chat");
this.subject.didOpenDrawer("/foo");
@ -138,13 +138,13 @@ module(
this.subject.didOpenDrawer();
assert.strictEqual(this.state.isDrawerActive, true);
assert.strictEqual(this.state.isDrawerExpanded, true);
assert.true(this.state.isDrawerActive);
assert.true(this.state.isDrawerExpanded);
this.subject.didCloseDrawer();
assert.strictEqual(this.state.isDrawerActive, false);
assert.strictEqual(this.state.isDrawerExpanded, false);
assert.false(this.state.isDrawerActive);
assert.false(this.state.isDrawerExpanded);
resetChatDrawerStateCallbacks();
});