github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

A mucher saner API for updating the title of routes, even when nested.

Browse Source 
Properly sends the title of the page to google analytics
This commit is contained in:
Robin Ward
2014-10-09 14:37:23 -04:00
parent e8637344c3
commit 5fc150e057
17 changed files with 106 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse.js
View File

@ -10,6 +10,7 @@ var DiscourseResolver = require('discourse/ember/resolver').default;
window.Discourse = Ember.Application.createWithMixins(Discourse.Ajax, {
rootElement: '#main',
_docTitle: null,
getURL: function(url) {
// If it's a non relative URL, return it.
@ -25,13 +26,8 @@ window.Discourse = Ember.Application.createWithMixins(Discourse.Ajax, {
Resolver: DiscourseResolver,
titleChanged: function() {
var title = "";
if (this.get('title')) {
title += "" + (this.get('title')) + " - ";
}
title += Discourse.SiteSettings.title;
_titleChanged: function() {
var title = this.get('_docTitle') || Discourse.SiteSettings.title;
// if we change this we can trigger changes on document.title
// only set if changed.
@ -44,14 +40,14 @@ window.Discourse = Ember.Application.createWithMixins(Discourse.Ajax, {
title = "(" + notifyCount + ") " + title;
}
if(title !== document.title) {
if (title !== document.title) {
// chrome bug workaround see: http://stackoverflow.com/questions/2952384/changing-the-window-title-when-focussing-the-window-doesnt-work-in-chrome
window.setTimeout(function() {
document.title = ".";
document.title = title;
}, 200);
}
}.observes('title', 'hasFocus', 'notifyCount'),
}.observes('_docTitle', 'hasFocus', 'notifyCount'),
faviconChanged: function() {
if(Discourse.User.currentProp('dynamic_favicon')) {