github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Store special characters in permalink URL as encoded characters

Browse Source 
see https://meta.discourse.org/t/permalink-not-working-with-cyrilics-symbols/301130
This commit is contained in:
Gerhard Schlager
2024-05-27 22:33:30 +02:00
committed by Gerhard Schlager
parent 9061282515
commit 602ef2c819
2 changed files with 43 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
spec/models/permalink_spec.rb
View File

@ -13,14 +13,40 @@ RSpec.describe Permalink do
describe "new record" do
it "strips blanks" do
permalink = described_class.create(url: " my/old/url ")
permalink = described_class.create!(url: " my/old/url ")
expect(permalink.url).to eq("my/old/url")
end
it "removes leading slash" do
permalink = described_class.create(url: "/my/old/url")
permalink = described_class.create!(url: "/my/old/url")
expect(permalink.url).to eq("my/old/url")
end
it "checks for unique URL" do
permalink = described_class.create(url: "/my/old/url")
expect(permalink.errors[:url]).to be_empty
permalink = described_class.create(url: "/my/old/url")
expect(permalink.errors[:url]).to be_present
permalink = described_class.create(url: "my/old/url")
expect(permalink.errors[:url]).to be_present
end
context "with special characters in URL" do
it "percent encodes any special character" do
permalink = described_class.create!(url: "/2022/10/03/привет-sam")
expect(permalink.url).to eq("2022/10/03/%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82-sam")
end
it "checks for unique URL" do
permalink = described_class.create(url: "/2022/10/03/привет-sam")
expect(permalink.errors[:url]).to be_empty
permalink = described_class.create(url: "/2022/10/03/привет-sam")
expect(permalink.errors[:url]).to be_present
end
end
end
describe "target_url" do