github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: various improvements to devex on chat (#21612)

Browse Source 
- Improves styleguide support
- Adds toggle color scheme to styleguide
- Adds properties mutators to styleguide
- Attempts to quit a session as soon as done with it in system specs, this should at least free resources faster
- Refactors fabricators to simplify them
- Adds more fabricators (uploads for example)
- Starts implementing components pattern in system specs
- Uses Chat::Message creator to create messages in system specs, this should help to have more real specs as the side effects should now happen
This commit is contained in:
Joffrey JAFFEUX
2023-05-17 17:49:52 +02:00
committed by GitHub
parent 4d0b997559
commit 60c67afba4
75 changed files with 1002 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/test/javascripts/components/chat-channel-status-test.js
View File

@ -3,7 +3,7 @@ import hbs from "htmlbars-inline-precompile";
import I18n from "I18n";
import { module, test } from "qunit";
import { render } from "@ember/test-helpers";
import fabricators from "../helpers/fabricators";
import fabricators from "discourse/plugins/chat/discourse/lib/fabricators";
import {
CHANNEL_STATUSES,
channelStatusIcon,
@ -13,7 +13,7 @@ module("Discourse Chat | Component | chat-channel-status", function (hooks) {
setupRenderingTest(hooks);
test("renders nothing when channel is opened", async function (assert) {
this.channel = fabricators.chatChannel();
this.channel = fabricators.channel();
await render(hbs`<ChatChannelStatus @channel={{this.channel}} />`);
@ -21,7 +21,7 @@ module("Discourse Chat | Component | chat-channel-status", function (hooks) {
});
test("defaults to long format", async function (assert) {
this.channel = fabricators.chatChannel({ status: CHANNEL_STATUSES.closed });
this.channel = fabricators.channel({ status: CHANNEL_STATUSES.closed });
await render(hbs`<ChatChannelStatus @channel={{this.channel}} />`);
@ -31,7 +31,7 @@ module("Discourse Chat | Component | chat-channel-status", function (hooks) {
});
test("accepts a format argument", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
status: CHANNEL_STATUSES.archived,
});
@ -45,7 +45,7 @@ module("Discourse Chat | Component | chat-channel-status", function (hooks) {
});
test("renders the correct icon", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
status: CHANNEL_STATUSES.archived,
});
@ -56,7 +56,7 @@ module("Discourse Chat | Component | chat-channel-status", function (hooks) {
test("renders archive status", async function (assert) {
this.currentUser.admin = true;
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
status: CHANNEL_STATUSES.archived,
archive_failed: true,
});