github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 07:11:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: various improvements to devex on chat (#21612)

Browse Source 
- Improves styleguide support
- Adds toggle color scheme to styleguide
- Adds properties mutators to styleguide
- Attempts to quit a session as soon as done with it in system specs, this should at least free resources faster
- Refactors fabricators to simplify them
- Adds more fabricators (uploads for example)
- Starts implementing components pattern in system specs
- Uses Chat::Message creator to create messages in system specs, this should help to have more real specs as the side effects should now happen
This commit is contained in:
Joffrey JAFFEUX
2023-05-17 17:49:52 +02:00
committed by GitHub
parent 4d0b997559
commit 60c67afba4
75 changed files with 1002 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/chat/test/javascripts/components/chat-channel-title-test.js
View File

@ -1,7 +1,7 @@
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { exists, query } from "discourse/tests/helpers/qunit-helpers";
import hbs from "htmlbars-inline-precompile";
import fabricators from "../helpers/fabricators";
import fabricators from "discourse/plugins/chat/discourse/lib/fabricators";
import { CHATABLE_TYPES } from "discourse/plugins/chat/discourse/models/chat-channel";
import { module, test } from "qunit";
import { render } from "@ember/test-helpers";
@ -10,7 +10,7 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
setupRenderingTest(hooks);
test("category channel", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
chatable_type: CHATABLE_TYPES.categoryChannel,
});
@ -27,7 +27,7 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
});
test("category channel - escapes title", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
chatable_type: CHATABLE_TYPES.categoryChannel,
title: "<div class='xss'>evil</div>",
});
@ -38,7 +38,7 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
});
test("category channel - read restricted", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
chatable_type: CHATABLE_TYPES.categoryChannel,
chatable: { read_restricted: true },
});
@ -49,7 +49,7 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
});
test("category channel - not read restricted", async function (assert) {
this.channel = fabricators.chatChannel({
this.channel = fabricators.channel({
chatable_type: CHATABLE_TYPES.categoryChannel,
chatable: { read_restricted: false },
});
@ -60,7 +60,11 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
});
test("direct message channel - one user", async function (assert) {
this.channel = fabricators.directMessageChatChannel();
this.channel = fabricators.directMessageChannel({
chatable: fabricators.directMessage({
users: [fabricators.user()],
}),
});
await render(hbs`<ChatChannelTitle @channel={{this.channel}} />`);
@ -77,7 +81,7 @@ module("Discourse Chat | Component | chat-channel-title", function (hooks) {
});
test("direct message channel - multiple users", async function (assert) {
const channel = fabricators.directMessageChatChannel();
const channel = fabricators.directMessageChannel();
channel.chatable.users.push({
id: 2,