github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 06:28:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Replace custom Onebox blank implementation with ActiveSupport (#23827)

Browse Source 
We have a custom implementation of #blank? in our Onebox helpers. This is likely a legacy from when Onebox was a standalone gem. This change replaces all usages with respective incarnations of #blank?, #present?, and #presence from ActiveSupport. It changes a bunch of "unless blank" to "if present" as well.
This commit is contained in:
Ted Johansson
2023-10-07 19:54:26 +02:00
committed by GitHub
parent 85c6914f80
commit 60e624e768
15 changed files with 42 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/onebox/engine/audio_com_onebox.rb
View File

@ -17,7 +17,7 @@ module Onebox
def placeholder_html
oembed = get_oembed
return if Onebox::Helpers.blank?(oembed.thumbnail_url)
return if oembed.thumbnail_url.blank?
"<img src='#{oembed.thumbnail_url}' #{oembed.title_attr}>"
end