github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Replace custom Onebox blank implementation with ActiveSupport (#23827)

Browse Source 
We have a custom implementation of #blank? in our Onebox helpers. This is likely a legacy from when Onebox was a standalone gem. This change replaces all usages with respective incarnations of #blank?, #present?, and #presence from ActiveSupport. It changes a bunch of "unless blank" to "if present" as well.
This commit is contained in:
Ted Johansson
2023-10-07 19:54:26 +02:00
committed by GitHub
parent 85c6914f80
commit 60e624e768
15 changed files with 42 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/onebox/engine/google_docs_onebox.rb
View File

@ -22,7 +22,7 @@ module Onebox
short_type = SHORT_TYPES[match[:endpoint].to_sym]
description =
if Onebox::Helpers.blank?(og_data.description)
if og_data.description.blank?
"This #{short_type.to_s.chop.capitalize} is private"
else
Onebox::Helpers.truncate(og_data.description, 250)