github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-05 08:07:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: twitter_summary_large_image is renamed to x (#31870)

Browse Source 
In this PR x_summary_large_image was introduced but now updated in all
places.

Also `min_first_post_typing_time` deprecation should not be removed.
This commit is contained in:
Krzysztof Kotlarek
2025-03-19 11:55:11 +11:00
committed by GitHub
parent a34e0433cc
commit 622d681f96
5 changed files with 19 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/helpers/application_helper_spec.rb
View File

@ -626,7 +626,7 @@ RSpec.describe ApplicationHelper do
it "returns the correct image" do
SiteSetting.opengraph_image = Fabricate(:upload, url: "/images/og-image.png")
SiteSetting.twitter_summary_large_image = Fabricate(:upload, url: "/images/twitter.png")
SiteSetting.x_summary_large_image = Fabricate(:upload, url: "/images/twitter.png")
SiteSetting.large_icon = Fabricate(:upload, url: "/images/large_icon.png")
@ -641,11 +641,9 @@ RSpec.describe ApplicationHelper do
SiteSetting.opengraph_image = nil
expect(helper.crawlable_meta_data).to include(
SiteSetting.site_twitter_summary_large_image_url,
)
expect(helper.crawlable_meta_data).to include(SiteSetting.site_x_summary_large_image_url)
SiteSetting.twitter_summary_large_image = nil
SiteSetting.x_summary_large_image = nil
expect(helper.crawlable_meta_data).to include(SiteSetting.site_large_icon_url)
@ -675,13 +673,13 @@ RSpec.describe ApplicationHelper do
<meta name=\"twitter:image\" content=\"#{SiteSetting.site_logo_url}\" />
HTML
SiteSetting.twitter_summary_large_image = Fabricate(:upload, url: "/images/twitter.png")
SiteSetting.x_summary_large_image = Fabricate(:upload, url: "/images/twitter.png")
expect(helper.crawlable_meta_data).to include(<<~HTML)
<meta name=\"twitter:image\" content=\"#{SiteSetting.site_twitter_summary_large_image_url}\" />
<meta name=\"twitter:image\" content=\"#{SiteSetting.site_x_summary_large_image_url}\" />
HTML
SiteSetting.twitter_summary_large_image = Fabricate(:upload, url: "/images/twitter.svg")
SiteSetting.x_summary_large_image = Fabricate(:upload, url: "/images/twitter.svg")
expect(helper.crawlable_meta_data).to include(<<~HTML)
<meta name=\"twitter:image\" content=\"#{SiteSetting.site_logo_url}\" />