github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-06 03:06:53 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Replace deprecated render(buffer) with a custom buffered renderer

Browse Source
This commit is contained in:
Robin Ward
2016-10-24 15:21:44 -04:00
parent 52b338db62
commit 622dc82481
46 changed files with 198 additions and 430 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/assets/javascripts/discourse-common/components/combo-box.js.es6
View File

@ -1,13 +1,14 @@
import { bufferedRender } from 'discourse-common/lib/buffered-render';
import { on, observes } from 'ember-addons/ember-computed-decorators';
export default Ember.Component.extend({
export default Ember.Component.extend(bufferedRender({
tagName: 'select',
attributeBindings: ['tabindex', 'disabled'],
classNames: ['combobox'],
valueAttribute: 'id',
nameProperty: 'name',
render(buffer) {
buildBuffer(buffer) {
const nameProperty = this.get('nameProperty');
const none = this.get('none');
@ -48,11 +49,11 @@ export default Ember.Component.extend({
@observes('content.[]')
_rerenderOnChange() {
this.rerender();
this.rerenderBuffer();
},
@on('didInsertElement')
_initializeCombo() {
didInsertElement() {
this._super();
// Workaround for https://github.com/emberjs/ember.js/issues/9813
// Can be removed when fixed. Without it, the wrong option is selected
@ -60,7 +61,7 @@ export default Ember.Component.extend({
// observer for item names changing (optional)
if (this.get('nameChanges')) {
this.addObserver('content.@each.' + this.get('nameProperty'), this.rerender);
this.addObserver('content.@each.' + this.get('nameProperty'), this.rerenderBuffer);
}
const $elem = this.$();
@ -88,4 +89,4 @@ export default Ember.Component.extend({
this.$().select2('destroy');
}
});
}));