mirror of
https://github.com/discourse/discourse.git
synced 2025-05-22 22:43:33 +08:00
FEATURE: Promote bookmarks with reminders to core functionality (#9369)
The main thrust of this PR is to take all the conditional checks based on the `enable_bookmarks_with_reminders` away and only keep the code from the `true` path, making bookmarks with reminders the core bookmarks feature. There is also a migration to create `Bookmark` records out of `PostAction` bookmarks for a site. ### Summary * Remove logic based on whether enable_bookmarks_with_reminders is true. This site setting is now obsolete, the old bookmark functionality is being removed. Retain the setting and set the value to `true` in a migration. * Use the code from the rake task to create a database migration that creates bookmarks from post actions. * Change the bookmark report to read from the new table. * Get rid of old endpoints for bookmarks * Link to the new bookmarks list from the user summary page
This commit is contained in:
@ -488,26 +488,6 @@ class PostsController < ApplicationController
|
||||
render body: nil
|
||||
end
|
||||
|
||||
def bookmark
|
||||
if params[:bookmarked] == "true"
|
||||
post = find_post_from_params
|
||||
result = PostActionCreator.create(current_user, post, :bookmark)
|
||||
return render_json_error(result) if result.failed?
|
||||
else
|
||||
post_action = PostAction.find_by(post_id: params[:post_id], user_id: current_user.id)
|
||||
raise Discourse::NotFound unless post_action
|
||||
|
||||
post = Post.with_deleted.find_by(id: post_action&.post_id)
|
||||
raise Discourse::NotFound unless post
|
||||
|
||||
result = PostActionDestroyer.destroy(current_user, post, :bookmark)
|
||||
return render_json_error(result) if result.failed?
|
||||
end
|
||||
|
||||
topic_user = TopicUser.get(post.topic, current_user)
|
||||
render_json_dump(topic_bookmarked: topic_user.try(:bookmarked))
|
||||
end
|
||||
|
||||
def destroy_bookmark
|
||||
params.require(:post_id)
|
||||
|
||||
|
Reference in New Issue
Block a user