FIX: on upgrade via discourse docker client json not updating

config/initializers/05-site_settings.rb

@@ -1,3 +1,8 @@
+# load up git version into memory
+# this way if it changes underneath we still have
+# the original version
+Discourse.git_version
+
 reload_settings = lambda {
   RailsMultisite::ConnectionManagement.each_connection do
     begin

lib/site_setting_extension.rb

@@ -177,7 +177,10 @@ module SiteSettingExtension
   end
 
   def self.client_settings_cache_key
-    "client_settings_json"
+    # NOTE: we use the git version in the key to ensure
+    # that we don't end up caching the incorrect version
+    # in cases where we are cycling unicorns
+    "client_settings_json_#{Discourse.git_version}"
   end
 
   # refresh all the site settings