github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 02:01:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not add empty use/svg tags in ExcerptParser (#19969)

Browse Source 
There was an issue where if hashtag-cooked HTML was sent
to the ExcerptParser without the keep_svg option, we would
end up with empty </use> and </svg> tags on the parts of the
excerpt where the hashtag was, in this case when a post
push notification was sent.

Fixed this, and also added a way to only display a plaintext
version of the hashtag for cases like this via PrettyText#excerpt.
This commit is contained in:
Martin Brennan
2023-01-24 14:40:24 +10:00
committed by GitHub
parent 799202d50b
commit 63fdb6dd65
5 changed files with 39 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/excerpt_parser.rb
View File

@ -181,10 +181,10 @@ class ExcerptParser < Nokogiri::XML::SAX::Document
when "div", "span"
throw :done if @start_excerpt
when "svg"
characters("</svg>", truncate: false, count_it: false, encode: false)
characters("</svg>", truncate: false, count_it: false, encode: false) if @keep_svg
@in_svg = false
when "use"
characters("</use>", truncate: false, count_it: false, encode: false)
characters("</use>", truncate: false, count_it: false, encode: false) if @keep_svg
end
end