mirror of
https://github.com/discourse/discourse.git
synced 2025-05-30 23:38:29 +08:00
FIX: Don't rate limit admin and staff constraints when matching routes.
* When an error is raised when checking route constraints, we can only return true/false which either lets the request through or return a 404 error. Therefore, we just skip rate limiting here and let the controller handle the rate limiting.
This commit is contained in:
@ -2,18 +2,19 @@ require 'rails_helper'
|
||||
require_dependency 'auth/default_current_user_provider'
|
||||
|
||||
describe Auth::DefaultCurrentUserProvider do
|
||||
let(:rate_limit) { true }
|
||||
|
||||
class TestProvider < Auth::DefaultCurrentUserProvider
|
||||
attr_reader :env
|
||||
def initialize(env)
|
||||
super(env)
|
||||
def initialize(env, rate_limit: true)
|
||||
super(env, rate_limit: rate_limit)
|
||||
end
|
||||
end
|
||||
|
||||
def provider(url, opts = nil)
|
||||
opts ||= { method: "GET" }
|
||||
env = Rack::MockRequest.env_for(url, opts)
|
||||
TestProvider.new(env)
|
||||
TestProvider.new(env, rate_limit: rate_limit)
|
||||
end
|
||||
|
||||
it "can be used to pretend that a user doesn't exist" do
|
||||
@ -145,6 +146,26 @@ describe Auth::DefaultCurrentUserProvider do
|
||||
provider("/?api_key=#{key}&api_username=#{user.username.downcase}").current_user
|
||||
|
||||
end
|
||||
|
||||
describe 'when rate limit is disabled' do
|
||||
let(:rate_limit) { false }
|
||||
|
||||
it 'should not raise any rate limit errors' do
|
||||
global_setting :max_admin_api_reqs_per_key_per_minute, 1
|
||||
|
||||
freeze_time
|
||||
|
||||
key = SecureRandom.hex
|
||||
api_key = ApiKey.create!(key: key, created_by_id: -1)
|
||||
|
||||
2.times do
|
||||
provider(
|
||||
"/?api_key=#{key}&api_username=system",
|
||||
nil
|
||||
).current_user
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
Reference in New Issue
Block a user