github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 09:08:10 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: add dominant color attribute to chat image uploads (#24214)

Browse Source 
When uploading images, they are assigned a dominant color which gets used in various places, such as Discourse Hub and the new lightbox. Previously in chat we didn't assign this attribute, so it was defaulting to a null value. We did however use it as an inline CSS style for the image background (which is visible while the image is downloaded).

This change adds data-dominant-color to the uploaded image in chat and uses it correctly within lightbox.
This commit is contained in:
David Battersby
2023-11-02 19:22:59 +08:00
committed by GitHub
parent c38bbdf88a
commit 65759c126b
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/chat/spec/system/uploads_spec.rb
View File

@ -39,6 +39,20 @@ describe "Uploading files in chat messages", type: :system do
expect(Chat::Message.last.uploads.count).to eq(1)
end
it "adds dominant color attribute to images" do
chat.visit_channel(channel_1)
file_path = file_from_fixtures("logo.png", "images").path
attach_file(file_path) do
channel_page.open_action_menu
channel_page.click_action_button("chat-upload-btn")
end
channel_page.click_send_message
expect(channel_page.messages).to have_css(".chat-img-upload[data-dominant-color]", count: 1)
end
it "allows uploading multiple files" do
chat.visit_channel(channel_1)