github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 02:48:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove the use of Capybara::Session#quit (#24978)

Browse Source 
Why this change?

This is what `Capybara::Session#quit` does:

```
    def quit
      @driver.quit if @driver.respond_to? :quit
      @document = @driver = nil
      @touched = false
      @server&.reset_error!
    end
```

One notable thing is that it resets server errors which means that any
server errors encountered by a session is cleared. That is not what we
want since it hides errors even though `Capybara.raise_server_errors`
has been set to `true`.
This commit is contained in:
Alan Guo Xiang Tan
2023-12-20 13:20:14 +08:00
committed by GitHub
parent 043fa28fab
commit 68a3f7783e
12 changed files with 21 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/chat/spec/system/chat_channel_spec.rb
View File

@ -104,14 +104,10 @@ RSpec.describe "Chat channel", type: :system do
chat_page.visit_channel(channel_1)
end
using_session(:tab_1) do |session|
channel_page.send_message("test_message")
session.quit
end
using_session(:tab_1) { channel_page.send_message("test_message") }
using_session(:tab_2) do |session|
using_session(:tab_2) do
expect(channel_page.messages).to have_message(text: "test_message")
session.quit
end
end
end