github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-03 02:48:28 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Remove the use of Capybara::Session#quit (#24978)

Browse Source 
Why this change?

This is what `Capybara::Session#quit` does:

```
    def quit
      @driver.quit if @driver.respond_to? :quit
      @document = @driver = nil
      @touched = false
      @server&.reset_error!
    end
```

One notable thing is that it resets server errors which means that any
server errors encountered by a session is cleared. That is not what we
want since it hides errors even though `Capybara.raise_server_errors`
has been set to `true`.
This commit is contained in:
Alan Guo Xiang Tan
2023-12-20 13:20:14 +08:00
committed by GitHub
parent 043fa28fab
commit 68a3f7783e
12 changed files with 21 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/spec/system/restore_message_spec.rb
View File

@ -35,16 +35,14 @@ RSpec.describe "Restore message", type: :system do
chat_page.visit_channel(channel_1)
end
using_session(:regular_user) do |session|
using_session(:regular_user) do
sign_in(regular_user)
chat_page.visit_channel(channel_1)
channel_page.messages.delete(message_1)
session.quit
end
using_session(:another_user) do |session|
using_session(:another_user) do
expect(channel_page.messages).to have_no_message(id: message_1.id)
session.quit
end
end
end
@ -58,18 +56,16 @@ RSpec.describe "Restore message", type: :system do
chat_page.visit_channel(channel_1)
end
using_session(:admin_user) do |session|
using_session(:admin_user) do
sign_in(admin_user)
chat_page.visit_channel(channel_1)
channel_page.messages.delete(message_1)
session.quit
end
using_session(:regular_user) do |session|
using_session(:regular_user) do
expect(channel_page.messages).to have_deleted_message(message_1, count: 1)
channel_page.messages.expand(id: message_1.id)
expect(channel_page.messages).to have_no_action("restore", id: message_1.id)
session.quit
end
end
end