github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 07:53:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: use an algorithm that doesn't re-order percentages when rounding them up to 100% in single choice polls

Browse Source
This commit is contained in:
Régis Hanol
2015-11-25 00:14:24 +01:00
parent 434deb1bd3
commit 68a44a1d59
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/poll/assets/javascripts/lib/even-round.js.es6
View File

@ -1,8 +1,9 @@
// stolen from http://stackoverflow.com/a/13485888/11983
// stolen from http://stackoverflow.com/a/13484088/11983
export default (percentages) => {
const off = 100 - _.reduce(percentages, (acc, x) => acc + Math.round(x), 0);
return _.chain(percentages)
.sortBy(x => Math.round(x) - x)
.map((x, i) => Math.round(x) + (off > i) - (i >= (percentages.length + off)))
.value();
const sumOfDecimals = Math.ceil(percentages.map(a => a % 1).reduce((a, b) => a + b));
// compensate error by adding 1 to the first n items
for (let i = 0; i < sumOfDecimals; i++) {
percentages[i] = ++percentages[i];
}
return percentages.map(a => Math.floor(a));
};