github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 09:58:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not overwrite existing thumbnails (#21199)

Browse Source 
* FIX: Do not overwrite existing thumbnails

When auto generating video thumbnails they should not overwrite any
existing topic thumbnails.

This also addresses an issue with capitalized file extensions like .MOV
that were being excluded.

* Update app/models/post.rb

Remove comment

Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>

---------

Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
This commit is contained in:
Blake Erickson
2023-04-21 13:33:33 -06:00
committed by GitHub
parent 56115977c0
commit 6ae0c42c01
2 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spec/models/post_spec.rb
View File

@ -1566,6 +1566,17 @@ RSpec.describe Post do
post.topic.reload
expect(post.topic.topic_thumbnails.length).to eq(0)
end
it "does not overwrite existing thumbnails" do
image_upload.original_filename = "#{video_upload.sha1}.png"
image_upload.save!
post.topic.image_upload_id = image_upload_2.id
post.topic.save!
post.link_post_uploads
post.topic.reload
expect(post.topic.image_upload_id).to eq(image_upload_2.id)
end
end
describe "uploads" do