mirror of
https://github.com/discourse/discourse.git
synced 2025-05-21 18:12:32 +08:00
DEV: rework the chat-live-pane (#20519)
This PR is introducing glimmer usage in the chat-live-pane, for components but also for models. RestModel usage has been dropped in favor of native classes. Other changes/additions in this PR: sticky dates, scrolling will now keep the date separator of the current section at the top of the screen better unread management, marking a channel as unread will correctly mark the correct message and not mark the whole channel as read. Tracking state will also now correctly return unread count and unread mentions. adds an animation on bottom arrow better scrolling behavior, we should now always correctly keep the scroll position while loading more reactions are now more reactive, and will update their tooltip without needed to close/reopen it skeleton has been improved with placeholder images and reactions when making a reaction on the desktop message actions, the menu won't move anymore simplify logic and stop maintaining a list of unloaded messages
This commit is contained in:
@ -1,5 +1,5 @@
|
||||
import User from "discourse/models/user";
|
||||
import { render, waitFor } from "@ember/test-helpers";
|
||||
import { render } from "@ember/test-helpers";
|
||||
import ChatMessage from "discourse/plugins/chat/discourse/models/chat-message";
|
||||
import { exists } from "discourse/tests/helpers/qunit-helpers";
|
||||
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
||||
@ -21,9 +21,16 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
unread_count: 0,
|
||||
muted: false,
|
||||
},
|
||||
canInteractWithChat: true,
|
||||
canDeleteSelf: true,
|
||||
canDeleteOthers: true,
|
||||
canFlag: true,
|
||||
userSilenced: false,
|
||||
canModerate: true,
|
||||
});
|
||||
return {
|
||||
message: ChatMessage.create(
|
||||
chatChannel,
|
||||
Object.assign(
|
||||
{
|
||||
id: 178,
|
||||
@ -38,14 +45,6 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
messageData
|
||||
)
|
||||
),
|
||||
canInteractWithChat: true,
|
||||
details: {
|
||||
can_delete_self: true,
|
||||
can_delete_others: true,
|
||||
can_flag: true,
|
||||
user_silenced: false,
|
||||
can_moderate: true,
|
||||
},
|
||||
chatChannel,
|
||||
setReplyTo: () => {},
|
||||
replyMessageClicked: () => {},
|
||||
@ -55,8 +54,9 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
onStartSelectingMessages: () => {},
|
||||
onSelectMessage: () => {},
|
||||
bulkSelectMessages: () => {},
|
||||
afterReactionAdded: () => {},
|
||||
onHoverMessage: () => {},
|
||||
didShowMessage: () => {},
|
||||
didHideMessage: () => {},
|
||||
};
|
||||
}
|
||||
|
||||
@ -64,8 +64,7 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
<ChatMessage
|
||||
@message={{this.message}}
|
||||
@canInteractWithChat={{this.canInteractWithChat}}
|
||||
@details={{this.details}}
|
||||
@chatChannel={{this.chatChannel}}
|
||||
@channel={{this.chatChannel}}
|
||||
@setReplyTo={{this.setReplyTo}}
|
||||
@replyMessageClicked={{this.replyMessageClicked}}
|
||||
@editButtonClicked={{this.editButtonClicked}}
|
||||
@ -74,7 +73,8 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
@onSelectMessage={{this.onSelectMessage}}
|
||||
@bulkSelectMessages={{this.bulkSelectMessages}}
|
||||
@onHoverMessage={{this.onHoverMessage}}
|
||||
@afterReactionAdded={{this.reStickScrollIfNeeded}}
|
||||
@didShowMessage={{this.didShowMessage}}
|
||||
@didHideMessage={{this.didHideMessage}}
|
||||
/>
|
||||
`;
|
||||
|
||||
@ -90,6 +90,7 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
test("Deleted message", async function (assert) {
|
||||
this.setProperties(generateMessageProps({ deleted_at: moment() }));
|
||||
await render(template);
|
||||
|
||||
assert.true(
|
||||
exists(".chat-message-deleted .chat-message-expand"),
|
||||
"has the correct deleted css class and expand button within"
|
||||
@ -104,16 +105,4 @@ module("Discourse Chat | Component | chat-message", function (hooks) {
|
||||
"has the correct hidden css class and expand button within"
|
||||
);
|
||||
});
|
||||
|
||||
test("Message marked as visible", async function (assert) {
|
||||
this.setProperties(generateMessageProps());
|
||||
|
||||
await render(template);
|
||||
await waitFor("div[data-visible=true]");
|
||||
|
||||
assert.true(
|
||||
exists(".chat-message-container[data-visible=true]"),
|
||||
"message is marked as visible"
|
||||
);
|
||||
});
|
||||
});
|
||||
|
Reference in New Issue
Block a user