github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Eliminate flakiness in specs that depend on plugins from fixtures (#21912)

Browse Source
This commit is contained in:
Osama Sayegh
2023-06-05 03:06:00 +03:00
committed by GitHub
parent 41836762c4
commit 6cf863080a
7 changed files with 31 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/lib/stylesheet/compiler_spec.rb
View File

@ -56,15 +56,13 @@ RSpec.describe Stylesheet::Compiler do
context "with a plugin" do
let :plugin1 do
plugin1 = Plugin::Instance.new
plugin1.path = "#{Rails.root}/spec/fixtures/plugins/my_plugin/plugin.rb"
plugin1 = plugin_from_fixtures("my_plugin")
plugin1.register_css "body { background: $primary }"
plugin1
end
let :plugin2 do
plugin2 = Plugin::Instance.new
plugin2.path = "#{Rails.root}/spec/fixtures/plugins/scss_plugin/plugin.rb"
plugin2 = plugin_from_fixtures("scss_plugin")
plugin2
end
@ -183,8 +181,7 @@ RSpec.describe Stylesheet::Compiler do
context "with a plugin" do
before do
plugin = Plugin::Instance.new
plugin.path = "#{Rails.root}/spec/fixtures/plugins/color_definition/plugin.rb"
plugin = plugin_from_fixtures("color_definition")
Discourse.plugins << plugin
plugin.activate!
end

6
spec/lib/stylesheet/manager_spec.rb
View File

@ -1014,15 +1014,13 @@ RSpec.describe Stylesheet::Manager do
context "when there are enabled plugins" do
let(:plugin1) do
plugin1 = Plugin::Instance.new
plugin1.path = "#{Rails.root}/spec/fixtures/plugins/my_plugin/plugin.rb"
plugin1 = plugin_from_fixtures("my_plugin")
plugin1.register_css "body { padding: 1px 2px 3px 4px; }"
plugin1
end
let(:plugin2) do
plugin2 = Plugin::Instance.new
plugin2.path = "#{Rails.root}/spec/fixtures/plugins/scss_plugin/plugin.rb"
plugin2 = plugin_from_fixtures("scss_plugin")
plugin2
end