DEV: Allow fab! without block (#24314)

The most common thing that we do with fab! is:

    fab!(:thing) { Fabricate(:thing) }

This commit adds a shorthand for this which is just simply:

    fab!(:thing)

i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
Daniel Waterworth
2023-11-09 16:47:59 -06:00
committed by GitHub
parent d91456fd53
commit 6e161d3e75
471 changed files with 1277 additions and 1273 deletions

View File

@ -5,11 +5,11 @@ require "file_store/local_store"
RSpec.describe FileStore::LocalStore do
let(:store) { FileStore::LocalStore.new }
fab!(:upload) { Fabricate(:upload) }
fab!(:upload)
let(:uploaded_file) { file_from_fixtures("logo.png") }
let(:upload_path) { Discourse.store.upload_path }
fab!(:optimized_image) { Fabricate(:optimized_image) }
fab!(:optimized_image)
describe "#store_upload" do
it "returns a relative url" do

View File

@ -12,7 +12,7 @@ RSpec.describe FileStore::S3Store do
let(:s3_object) { stub }
let(:upload_path) { Discourse.store.upload_path }
fab!(:optimized_image) { Fabricate(:optimized_image) }
fab!(:optimized_image)
let(:optimized_image_file) { file_from_fixtures("logo.png") }
let(:uploaded_file) { file_from_fixtures("logo.png") }
fab!(:upload) { Fabricate(:upload, sha1: Digest::SHA1.hexdigest("secret image string")) }