DEV: Allow fab! without block (#24314)

The most common thing that we do with fab! is:

    fab!(:thing) { Fabricate(:thing) }

This commit adds a shorthand for this which is just simply:

    fab!(:thing)

i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
Daniel Waterworth
2023-11-09 16:47:59 -06:00
committed by GitHub
parent d91456fd53
commit 6e161d3e75
471 changed files with 1277 additions and 1273 deletions

View File

@ -1,11 +1,11 @@
# frozen_string_literal: true
RSpec.describe TopicsBulkAction do
fab!(:topic) { Fabricate(:topic) }
fab!(:topic)
describe "#dismiss_topics" do
fab!(:user) { Fabricate(:user, created_at: 1.days.ago) }
fab!(:category) { Fabricate(:category) }
fab!(:category)
fab!(:topic2) { Fabricate(:topic, category: category, created_at: 60.minutes.ago) }
fab!(:topic3) { Fabricate(:topic, category: category, created_at: 120.minutes.ago) }
@ -151,7 +151,7 @@ RSpec.describe TopicsBulkAction do
end
describe "change_category" do
fab!(:category) { Fabricate(:category) }
fab!(:category)
fab!(:fist_post) { Fabricate(:post, topic: topic) }
context "when the user can edit the topic" do
@ -261,7 +261,7 @@ RSpec.describe TopicsBulkAction do
describe "delete" do
fab!(:topic) { Fabricate(:post).topic }
fab!(:moderator) { Fabricate(:moderator) }
fab!(:moderator)
it "deletes the topic" do
tba = TopicsBulkAction.new(moderator, [topic.id], type: "delete")