DEV: Allow fab! without block (#24314)

The most common thing that we do with fab! is:

    fab!(:thing) { Fabricate(:thing) }

This commit adds a shorthand for this which is just simply:

    fab!(:thing)

i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
Daniel Waterworth
2023-11-09 16:47:59 -06:00
committed by GitHub
parent d91456fd53
commit 6e161d3e75
471 changed files with 1277 additions and 1273 deletions

View File

@ -5,7 +5,7 @@ RSpec.describe EmbedController do
let(:embed_url_secure) { "https://eviltrout.com/2013/02/10/why-discourse-uses-emberjs.html" }
let(:discourse_username) { "eviltrout" }
fab!(:topic) { Fabricate(:topic) }
fab!(:topic)
describe "#info" do
context "without api key" do
@ -172,7 +172,7 @@ RSpec.describe EmbedController do
end
describe "by topic id" do
fab!(:embeddable_host) { Fabricate(:embeddable_host) }
fab!(:embeddable_host)
it "allows a topic to be embedded by id" do
get "/embed/comments",
@ -188,7 +188,7 @@ RSpec.describe EmbedController do
end
context "with a host" do
fab!(:embeddable_host) { Fabricate(:embeddable_host) }
fab!(:embeddable_host)
before { Jobs.run_immediately! }