mirror of
https://github.com/discourse/discourse.git
synced 2025-06-04 20:24:47 +08:00
DEV: Allow fab! without block (#24314)
The most common thing that we do with fab! is: fab!(:thing) { Fabricate(:thing) } This commit adds a shorthand for this which is just simply: fab!(:thing) i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:

committed by
GitHub

parent
d91456fd53
commit
6e161d3e75
@ -64,10 +64,10 @@ RSpec.describe UserSerializer do
|
||||
context "with a user" do
|
||||
let(:admin_user) { Fabricate(:admin) }
|
||||
let(:scope) { Guardian.new }
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
let(:serializer) { UserSerializer.new(user, scope: scope, root: false) }
|
||||
let(:json) { serializer.as_json }
|
||||
fab!(:upload) { Fabricate(:upload) }
|
||||
fab!(:upload)
|
||||
fab!(:upload2) { Fabricate(:upload) }
|
||||
|
||||
context "when the scope user is admin" do
|
||||
@ -342,7 +342,7 @@ RSpec.describe UserSerializer do
|
||||
end
|
||||
|
||||
context "with custom_fields" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
let(:json) { UserSerializer.new(user, scope: Guardian.new, root: false).as_json }
|
||||
|
||||
before do
|
||||
@ -378,7 +378,7 @@ RSpec.describe UserSerializer do
|
||||
end
|
||||
|
||||
context "with user fields" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
|
||||
let! :fields do
|
||||
[
|
||||
@ -408,7 +408,7 @@ RSpec.describe UserSerializer do
|
||||
end
|
||||
|
||||
context "with user_api_keys" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
|
||||
it "sorts keys by last used time" do
|
||||
freeze_time
|
||||
@ -441,7 +441,7 @@ RSpec.describe UserSerializer do
|
||||
end
|
||||
|
||||
context "with user_passkeys" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
fab!(:passkey0) do
|
||||
Fabricate(:passkey_with_random_credential, user: user, created_at: 5.hours.ago)
|
||||
end
|
||||
|
Reference in New Issue
Block a user